Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Remove RayService tests from comopatibility-test.py #1395

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

kevin85421
Copy link
Member

Why are these changes needed?

There are thorough RayService tests in test_sample_rayservice_yamls.py. We can remove the sanity check test for RayService in compatibility-test.py.

Related issue number

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@kevin85421 kevin85421 marked this pull request as ready for review September 5, 2023 20:51
Copy link
Contributor

@architkulkarni architkulkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@kevin85421 kevin85421 merged commit 77d0bba into ray-project:master Sep 5, 2023
15 checks passed
z103cb pushed a commit to z103cb/kuberay that referenced this pull request Sep 11, 2023
…#1395)

[CI] Remove RayService tests from comopatibility-test.py
z103cb pushed a commit to z103cb/kuberay that referenced this pull request Sep 11, 2023
…#1395)

[CI] Remove RayService tests from comopatibility-test.py
lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
…#1395)

[CI] Remove RayService tests from comopatibility-test.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants