-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove GOARCH in ray-operator/Dockfile to support multi-arch images #1442
Conversation
E.g. with docker buildx build --platform linux/amd64,linux/arm64/v8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not familiar with buildx, and I haven't been able to find any documentation on removing GOARCH in ray-operator/Dockerfile to support multi-architecture images. Could you please share some relevant resources?
This PR is not that risky as my first thought. We use GitHub Actions to build images, and all GitHub-hosted runners are x86_64, so it is not that risky to remove the GOARCH
option.
Hi, @kevin85421 Basically, with Some resources: https://docs.docker.com/build/building/multi-platform/ https://www.docker.com/blog/multi-arch-build-and-images-the-simple-way/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to clone your fork and test this PR on my own. Can you provide more details about how you manually test this PR and what's your environments?
@kevin85421 Could you please check this again? |
E.g. with docker buildx build --platform linux/amd64,linux/arm64/v8
Why are these changes needed?
To support different architectures with multi-arch docker images with
docker buildx
, we should remove GOARCH=amd64 in Dockerfile.Related issue number
None.
Checks