-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
created HA example for API server #1461
Conversation
@z103cb, @tedhtchang, @anishasthana please take a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nit picks around spelling and not so obvious steps. Otherwise this is LGTM.
@tedhtchang. Can you take a look as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The instruction in the HACluster.md was very helpful to verify the PR. I found some spells but the PR LGTM. Thank you.
@kevin85421 can you. please, merge |
@kevin85421 still waiting for you to merge |
@tedhtchang looks like you have not approved this yet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't reviewed this PR, but two folks from IBM have approved it. Stamp.
Why are these changes needed?
There is a great document on Ray cluster HA with KubeRay https://docs.ray.io/en/master/cluster/kubernetes/user-guides/kuberay-gcs-ft.html. This PR shows how to do this using an API server.
It also implements changes to the API cluster to support this
The PR also provides step-by-step instructions for creating and testing the HA Ray cluster using the API server
Related issue number
Checks