Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Reenable rayjob sample yaml latest test #1464

Merged

Conversation

architkulkarni
Copy link
Contributor

@architkulkarni architkulkarni commented Sep 29, 2023

Why are these changes needed?

This PR reenables the rayjob sample yaml test that tests against the latest kuberay version. Previously it was skipped due to breaking changes in the API.

Related issue number

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

Signed-off-by: Archit Kulkarni <[email protected]>
@architkulkarni architkulkarni marked this pull request as ready for review October 2, 2023 20:32
Copy link
Member

@kevin85421 kevin85421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please open another PR to update the remaining tests to use v1.0.0-rc.0?

@architkulkarni architkulkarni merged commit dec8137 into ray-project:master Oct 2, 2023
22 of 23 checks passed
kevin85421 pushed a commit to kevin85421/kuberay that referenced this pull request Oct 17, 2023
This PR reenables the rayjob sample yaml test that tests against the latest kuberay version. Previously it was skipped due to breaking changes in the API.

---------

Signed-off-by: Archit Kulkarni <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants