[CI] Skip redis raycluster sample YAML test #1465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Archit Kulkarni <[email protected]>
kevin85421
approved these changes
Sep 29, 2023
There was a problem hiding this comment.
Good catch! It makes sense. The issue arises because we deleted all Kubernetes objects defined in the YAML file, including Redis. Consequently, the Kubernetes cleanup job failed to clear the Redis cache successfully, preventing the removal of the finalizer. We may keep the issue opening until we fix the test.
[Update]
We can close the issue @rueian will take the rest.
|
Thanks for finding the actual root cause! |
4 tasks
rueian
added a commit
to rueian/kuberay
that referenced
this pull request
Oct 13, 2023
This reverts commit 84c35ac.
4 tasks
kevin85421
pushed a commit
that referenced
this pull request
Oct 13, 2023
kevin85421
pushed a commit
to kevin85421/kuberay
that referenced
this pull request
Oct 17, 2023
My understanding is that the RayCluster sample YAML test framework only adds RayCluster CRs, but doesn't add the other resources in the sample YAML file (for example the external redis deployment). In the case of the external redis sample YAML, the sample YAML test started failing after ray-project#1412 and my tentative hypothesis is that the cleanup job added by the PR hangs if there's no external redis. For now, we should merge this PR to unbreak CI. Later, we can decide whether to properly support an end-to-end external redis test. Related issue number Closes ray-project#1459 Signed-off-by: Archit Kulkarni <[email protected]>
kevin85421
added a commit
that referenced
this pull request
Oct 17, 2023
kevin85421
pushed a commit
to kevin85421/kuberay
that referenced
this pull request
Oct 17, 2023
kevin85421
added a commit
that referenced
this pull request
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
My understanding is that the RayCluster sample YAML test framework only adds RayCluster CRs, but doesn't add the other resources in the sample YAML file (for example the external redis deployment). In the case of the external redis sample YAML, the sample YAML test started failing after #1412 and my tentative hypothesis is that the cleanup job added by the PR hangs if there's no external redis.
For now, we should merge this PR to unbreak CI. Later, we can decide whether to properly support an end-to-end external redis test.
Related issue number
Closes #1459
Checks