Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] GPU RayCluster doesn't work on GKE Autopilot #1470

Merged
merged 2 commits into from
Oct 6, 2023

Conversation

kevin85421
Copy link
Member

@kevin85421 kevin85421 commented Oct 6, 2023

Why are these changes needed?

GKE's Autopilot does not support GPU-using init containers, so we explicitly specify the resources for the init container instead of reusing the resources of the Ray container. The resource consumption of the init container should be constant. Hence, it is OK to hard-code the resources.

Related issue number

Closes #1349

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(
# Step 1: Create a GKE Autopilot cluster
gcloud container clusters create-auto kuberay-gpu-cluster --region=us-west1

# Step 2: Install a KubeRay operator with this PR
# Step 3: Install a RayCluster https://gist.github.com/kevin85421/ef4c3a0c7493e76edd3d2cab5cea33e4
# (Note that you need to add nodeSelector)

@kevin85421 kevin85421 marked this pull request as ready for review October 6, 2023 22:10
Copy link
Contributor

@architkulkarni architkulkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix! Once this makes it into the kuberay release, we can probably simplify some of the GKE instructions in our doc and just recommend users to use GKE autopilot going forward. (Depending of how stable we believe GKE Autopilot is)

},
Requests: v1.ResourceList{
v1.ResourceCPU: resource.MustParse("200m"),
v1.ResourceMemory: resource.MustParse("256Mi"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment here with some indication of why these numbers were chosen would be useful, perhaps a brief reminder of what the init container does

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated 9039f24

@kevin85421 kevin85421 merged commit 0a56cd4 into ray-project:master Oct 6, 2023
23 checks passed
kevin85421 added a commit to kevin85421/kuberay that referenced this pull request Oct 17, 2023
…ct#1470)

[Enhancement] GPU RayCluster doesn't work on GKE Autopilot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] GPU RayCluster doesn't work on GKE Autopilot
2 participants