-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] GPU RayCluster doesn't work on GKE Autopilot #1470
[Enhancement] GPU RayCluster doesn't work on GKE Autopilot #1470
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice fix! Once this makes it into the kuberay release, we can probably simplify some of the GKE instructions in our doc and just recommend users to use GKE autopilot going forward. (Depending of how stable we believe GKE Autopilot is)
}, | ||
Requests: v1.ResourceList{ | ||
v1.ResourceCPU: resource.MustParse("200m"), | ||
v1.ResourceMemory: resource.MustParse("256Mi"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A comment here with some indication of why these numbers were chosen would be useful, perhaps a brief reminder of what the init container does
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated 9039f24
…ct#1470) [Enhancement] GPU RayCluster doesn't work on GKE Autopilot
Why are these changes needed?
GKE's Autopilot does not support GPU-using init containers, so we explicitly specify the resources for the init container instead of reusing the resources of the Ray container. The resource consumption of the init container should be constant. Hence, it is OK to hard-code the resources.
Related issue number
Closes #1349
Checks