Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Remove unused variables in constant.go #1474

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

evalaiyc98
Copy link
Contributor

Why are these changes needed?

Maintaining code cleanliness is the best policy.
I believe that redundant variables should be deleted to avoid confusion in subsequent development.

Related issue number

#1472

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

Copy link
Member

@kevin85421 kevin85421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevin85421 kevin85421 merged commit eb59de4 into ray-project:master Oct 10, 2023
23 checks passed
@evalaiyc98 evalaiyc98 deleted the remove-unusage branch October 11, 2023 00:37
kevin85421 pushed a commit to kevin85421/kuberay that referenced this pull request Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants