Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating url use v1 #1577

Merged
merged 2 commits into from
Oct 31, 2023
Merged

updating url use v1 #1577

merged 2 commits into from
Oct 31, 2023

Conversation

blublinsky
Copy link
Contributor

Why are these changes needed?

As we are gearing to v1 this PR updates API server URLs to reflect V1

All proto files are updated to use V1 in URL. Additionally test files and readme were updated to reflect this change

Related issue number

Checks

  • [ x] I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • [ x] Manual tests
    • This PR is not tested :(

@blublinsky
Copy link
Contributor Author

@z103cb, @tedhtchang, @astefanutti pls, take a look

cc: @kevin85421

Copy link
Contributor

@z103cb z103cb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@tedhtchang tedhtchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blublinsky 4 file still have the the v1alpha2 curl examples. Do we need to change these?
./test/service/service:curl 'localhost:8888/apis/v1alpha2/namespaces/default/services'
./test/service/service:curl 'localhost:8888/apis/v1alpha2/services'
./test/service/service:curl -X DELETE localhost:8888/apis/v1alpha2/namespaces/default/services/test-v2
./test/service/serviceV1:curl -X POST 'localhost:8888/apis/v1alpha2/namespaces/default/services'
./test/service/serviceV2:curl -X POST 'localhost:8888/apis/v1alpha2/namespaces/default/services'
./test/job/query:curl -X GET 'localhost:8888/apis/v1alpha2/namespaces/default/jobs'
./test/job/query:curl -X GET 'localhost:8888/apis/v1alpha2/jobs'
./test/job/query:curl -X GET 'localhost:8888/apis/v1alpha2/namespaces/default/jobs/job-test'
./test/job/query:curl -X DELETE 'localhost:8888/apis/v1alpha2/namespaces/default/jobs/job-test' \

@blublinsky
Copy link
Contributor Author

Thanks @tedhtchang for catching this. fixed

@blublinsky
Copy link
Contributor Author

@kevin85421 I think this one is ready for commit

Copy link
Member

@kevin85421 kevin85421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rerun the failed CI tests. I will merge this PR when CI passes.

@kevin85421 kevin85421 self-assigned this Oct 31, 2023
@kevin85421 kevin85421 merged commit aab9871 into ray-project:master Oct 31, 2023
23 checks passed
@blublinsky blublinsky deleted the apiserver_v1 branch November 2, 2023 12:17
kevin85421 pushed a commit to kevin85421/kuberay that referenced this pull request Nov 2, 2023
kevin85421 added a commit that referenced this pull request Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants