[RayService][Health-Check][8/n] Add readiness / liveness probes #1674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin85421
force-pushed
the
add-probes
branch
from
499d683
to
8df58e9
Compare
23 tasks
kevin85421
commented
Nov 28, 2023
| @@ -58,6 +59,24 @@ def test_cluster_info(self): | |||
| """Execute "print(ray.cluster_resources())" in the head Pod.""" | |||
| EasyJobRule().assert_rule() | |||
|
|
|||
| def test_probe_injection(self): | |||
There was a problem hiding this comment.
-
Run the test with
kuberay/operator:v1.0.0. The test should fail.RAY_IMAGE=rayproject/ray:nightly OPERATOR_IMAGE=kuberay/operator:v1.0.0 python3 tests/compatibility-test.py BasicRayTestCase 2>&1
-
Run the test with
controller:latest(this PR). The test should pass.RAY_IMAGE=rayproject/ray:nightly OPERATOR_IMAGE=controller:latest python3 tests/compatibility-test.py BasicRayTestCase 2>&1
kevin85421
force-pushed
the
add-probes
branch
from
119dfc8
to
1ad0876
Compare
architkulkarni
approved these changes
Nov 29, 2023
4 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
KubeRay only includes readiness/liveness probes when GCS is enabled. Therefore, if GCS is not enabled and the Raylet/dashboard agent processes crash, they will not be detected. Hence, we should inject the probes no matter whether the GCS is enabled or not.
In #1656, we decide to offload the health check responsibilities, including the dashboard agent on Ray head and Ray Serve applications, to K8s and Ray. With this PR, all RayCluster custom resources have probes to check the status of the Raylet which is fate-sharing with the Ray dashboard agent.
The compatibility test
KubeRayHealthCheckTestCasefor Ray 1.13.0 will fail because Ray 1.13.0 does not support the/api/local_raylet_healthzhealth-check endpoint. See here for the evidence. It is acceptable to remove the compatibility test for Ray 1.13.0 because it lacks support for many KubeRay features, such as GCS FT, Autoscaler, and so on. Additionally, I have hardly heard of any users using versions older than Ray 2.4.0 in the past three months.Related issue number
Checks
restartPolicyisAlways.