[Feature] Support for overwriting the generated ray start command with a user-specified container command #1704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin85421
changed the title
architkulkarni
approved these changes
Dec 4, 2023
| @@ -0,0 +1,60 @@ | |||
| # This example config is used to describe how does the annotation "ray.io/overwrite-container-cmd" work. | |||
| # See kuberay/docs/guidance/pod-command.md for more details. | |||
There was a problem hiding this comment.
Suggested change
| # See kuberay/docs/guidance/pod-command.md for more details. | |
| # See kuberay/docs/guidance/pod-command.md for more details. |
Is this link still accurate? More generally, what's the plan to document this feature? (I guess we'll add a section in the doc in the Ray repo?)
There was a problem hiding this comment.
More generally, what's the plan to document this feature? (I guess we'll add a section in the doc in the Ray repo?)
Yes, I will update the doc later.
| # Because the annotation "ray.io/overwrite-container-cmd" is set to "true", | ||
| # KubeRay will overwrite the generated container command with `command` and | ||
| # `args` in the following. Hence, you need to specify the `ulimit` command | ||
| # by yourself to avoid Ray scalability issues. |
There was a problem hiding this comment.
I think it will be helpful for the user if we remind them what $KUBERAY_GEN_RAY_START_CMD means here, even though you already described it in the code.
8 tasks
architkulkarni
added a commit
to ray-project/ray
that referenced
this pull request
Dec 8, 2023
Update doc for ray-project/kuberay#1704. --------- Signed-off-by: Kai-Hsun Chen <[email protected]> Signed-off-by: Kai-Hsun Chen <[email protected]> Co-authored-by: Archit Kulkarni <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
KUBERAY_GEN_RAY_START_CMDfor both head and worker Pods to store theray startcommand generated by KubeRay.ray.io/overwrite-container-cmd: "true"to RayCluster, KubeRay will respect the container command/args provided by users.ulimit -n 65536and["/bin/bash", "-lc", "--"]by themselves.Related issue number
Closes #1560
Checks
ray-cluster.overwrite-command.yaml.Command,Args, and environment variableKUBERAY_GEN_RAY_START_CMD.Command,Args, and environment variableKUBERAY_GEN_RAY_START_CMD.