Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump controller-runtime to 0.11.1 and Kubernetes to v1.23 #180

Merged
merged 2 commits into from
Mar 15, 2022

Conversation

chenk008
Copy link
Contributor

@chenk008 chenk008 commented Mar 8, 2022

Why are these changes needed?

In kubeRay, we use controller-runtime to create K8s client, manage reconciler controllers. Currently we use 0.7.2, it is incompatible with logr v1.0.0. Bump the controller-runtime to 0.11.1, it will be compatible with logr and help kubeRay to follow the version upgrade of the K8s community.

Related issue number

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@chenk008 chenk008 requested a review from Jeffwan March 8, 2022 10:32
@Jeffwan
Copy link
Collaborator

Jeffwan commented Mar 8, 2022

Let's hold this change until we release v0.2.0. We pin stable version to 1.19 and that should work for cluster between 1.19-1.22

@Jeffwan
Copy link
Collaborator

Jeffwan commented Mar 14, 2022

We release v0.2.0 and this can be unblocked

@Jeffwan Jeffwan changed the title bump controller-runtime to 0.11.1 bump controller-runtime to 0.11.1 and Kubernetes to v1.23 Mar 14, 2022
@Jeffwan
Copy link
Collaborator

Jeffwan commented Mar 14, 2022

I update the title to include kubernetes which makes us easier to track changes later.

@Jeffwan
Copy link
Collaborator

Jeffwan commented Mar 14, 2022

The changes look good to me. Let's bump the version.

@asm582
Copy link
Contributor

asm582 commented Mar 14, 2022

@chenk008 @Jeffwan Thanks, I see two commits, should we squash the commits and merge this PR?

@Jeffwan
Copy link
Collaborator

Jeffwan commented Mar 15, 2022

@chenk008 @Jeffwan Thanks, I see two commits, should we squash the commits and merge this PR?

We enable "Squash and merge" for the repo by default. :D

@Jeffwan Jeffwan merged commit ee72afc into ray-project:master Mar 15, 2022
@Jeffwan Jeffwan mentioned this pull request Mar 15, 2022
4 tasks
chenk008 added a commit that referenced this pull request Mar 22, 2022
* bump controller-runtime to 0.11.1

* fix

Co-authored-by: wuhua.ck <[email protected]>
lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
…t#180)

* bump controller-runtime to 0.11.1

* fix

Co-authored-by: wuhua.ck <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants