run ./hack/update-codegen.sh in generate make target #1848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin85421
approved these changes
Jan 18, 2024
kevin85421
reviewed
Jan 18, 2024
ray-operator/Makefile
Outdated
| @@ -47,6 +47,7 @@ manifests: controller-gen ## Generate WebhookConfiguration, ClusterRole and Cust | |||
|
|
|||
| generate: controller-gen ## Generate code containing DeepCopy, DeepCopyInto, and DeepCopyObject method implementations. | |||
There was a problem hiding this comment.
Do we need to update the comments?
There was a problem hiding this comment.
updated, thanks
Signed-off-by: Andrew Sy Kim <[email protected]>
andrewsykim
force-pushed
the
add-update-codegen-to-generate
branch
from
3e773f1
to
2ee48ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
generatetarget should also run./hack/update-codegen.shRelated issue number
Checks