Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TPU] Add envtests for multi-host #1950

Merged
merged 3 commits into from
Feb 29, 2024

Conversation

kevin85421
Copy link
Member

@kevin85421 kevin85421 commented Feb 28, 2024

Why are these changes needed?

Add envtests for multi-host. This is the follow up for #1913.

Related issue number

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@kevin85421 kevin85421 marked this pull request as ready for review February 29, 2024 00:20
@kevin85421
Copy link
Member Author

cc @richardsliu @ryanaoleary would you mind reviewing this PR? Thanks!

Copy link
Contributor

@ryanaoleary ryanaoleary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevin85421 kevin85421 merged commit e7a00f9 into ray-project:master Feb 29, 2024
23 checks passed
@kevin85421 kevin85421 assigned kevin85421 and unassigned jjyao Mar 2, 2024
ravishtiwari pushed a commit to ravishtiwari/kuberay that referenced this pull request Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants