[Perf] Add a CPU-based training workload #2116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @andrewsykim |
andrewsykim
reviewed
May 3, 2024
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| train_fashion_mnist(num_workers=4) |
There was a problem hiding this comment.
Thoughts on making num_workers configurable with an environment variable? That would it make it easier to tweak in the perf tests
There was a problem hiding this comment.
Same with CPUs for resources_per_worker
There was a problem hiding this comment.
I will ask others to work on it.
|
LGTM! Tested this locally and confirmed it works. Thanks @kevin85421! |
jjyao
approved these changes
May 3, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Our scalability test requires some CPU-based workloads. This PR uses CPU to train a MNIST model. I also can run the RayJob successfully on my devbox.
Related issue number
Checks