Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update v1alpha1 RayCluster CRD and controllers #22

Merged
merged 5 commits into from
Sep 14, 2021

Conversation

Jeffwan
Copy link
Collaborator

@Jeffwan Jeffwan commented Sep 11, 2021

Address #13 #17 #21

  1. Bump k8s version to 1.19.x and Golang to 1.15
  2. Make API changes according to the discussion
  3. Have some refactor in controller (use common labels, simplify service creation, remove stale code not being used. )
  4. Update deploy manifests and examples

/cc @akanso @chenk008 @chaomengyuan

Bump the dependency versions
- Golang 1.15
- Kubernetes 1.19.14
- controller-runtime 0.7.2
- controller-tools 0.5.0

Signed-off-by: Jiaxin Shan <[email protected]>
- Rename `WorkerGroupsSpec` to `WorkerGroupSpecs`
- Remove HeadService and add ServiceType and EnableIngressin headGroupSpec
- Add EnableInTreeAutoscaling field
- Add rich information in RayClusterStatus

Signed-off-by: Jiaxin Shan <[email protected]>
1. Refactor some internal methods to make invoking chains clear
2. Clean up some stale codes

Signed-off-by: Jiaxin Shan <[email protected]>
@Jeffwan
Copy link
Collaborator Author

Jeffwan commented Sep 11, 2021

I am running and adding more tests to make sure it has good coverage.

Copy link
Collaborator

@akanso akanso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!
I know this PR is an exception, since it is the first big change. In the future we can try to keep the PRs smaller and more granular.

ray-operator/config/manager/kustomization.yaml Outdated Show resolved Hide resolved
ray-operator/controllers/common/pod.go Outdated Show resolved Hide resolved
ray-operator/controllers/common/pod.go Outdated Show resolved Hide resolved
ray-operator/controllers/common/status.go Outdated Show resolved Hide resolved
@Jeffwan
Copy link
Collaborator Author

Jeffwan commented Sep 11, 2021

This PR doesn't include ingress & in-tree autoscaler support in controllers. A separate PR will be cut later. After this change, future PRs will be small and manageable.

@Jeffwan Jeffwan merged commit 7965aab into ray-project:master Sep 14, 2021
@Jeffwan Jeffwan deleted the api_changes branch September 14, 2021 02:39
lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
* Bump k8s version to 1.19.x and golang to 1.15

Bump the dependency versions
- Golang 1.15
- Kubernetes 1.19.14
- controller-runtime 0.7.2
- controller-tools 0.5.0

Signed-off-by: Jiaxin Shan <[email protected]>

* Update v1alpha1 RayCluster CRD

- Rename `WorkerGroupsSpec` to `WorkerGroupSpecs`
- Remove HeadService and add ServiceType and EnableIngressin headGroupSpec
- Add EnableInTreeAutoscaling field
- Add rich information in RayClusterStatus

Signed-off-by: Jiaxin Shan <[email protected]>

* Update raycluster controller

1. Refactor some internal methods to make invoking chains clear
2. Clean up some stale codes

Signed-off-by: Jiaxin Shan <[email protected]>

* Update deploy manifests and examples

Signed-off-by: Jiaxin Shan <[email protected]>

* Address review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants