Update format by running gofumpt #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Jeffwan this is a code format update using gofumpt. We can use this tool to correct some of the code once a while. |
|
@wilsonwang371 This looks good to me. Can we use gofumpt in the CI? Any conflicts with existing gofmt? |
Yeah, I will do that, but I think we need to at first make sure our code format is fine. |
Jeffwan
approved these changes
Apr 27, 2022
There was a problem hiding this comment.
@wilsonwang371 Can we add a follow up PR to add the format tools into CI?
Jeffwan
changed the title
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Run gofumpt once a while to correct some of the file formats.
Related issue number
N/A
Checks