Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] Support adding custom accelerator to resources in rayStartParams #2425

Merged
merged 7 commits into from
Oct 8, 2024
Merged

[Refactor] Support adding custom accelerator to resources in rayStartParams #2425

merged 7 commits into from
Oct 8, 2024

Commits on Oct 3, 2024

  1. [Refactor] Support adding custom accelerator to resources in rayStart… 

    …Params
    @mounchin
    mounchin committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    64c07f2 View commit details
    Browse the repository at this point in the history

  2. Organize imports and rename function

    @mounchin
    mounchin committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    2f3bfc9 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2024

  1. Address comments and panic on error

    @mounchin
    mounchin committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    8478742 View commit details
    Browse the repository at this point in the history

  2. Add test for multiple custom accelerators

    @mounchin
    mounchin committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    30b2ab7 View commit details
    Browse the repository at this point in the history

  3. Wrap resources value with quotes while passing to ray start

    @mounchin
    mounchin committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    aefb0cd View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. Fix test case

    @mounchin
    mounchin committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    3bf9c5c View commit details
    Browse the repository at this point in the history

  2. Log error and continue, instead of panicing

    @mounchin
    mounchin committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    77cbd7b View commit details
    Browse the repository at this point in the history