[Feature][kubectl-plugin] return usage error when no entrypoint input #2503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewsykim
reviewed
Nov 6, 2024
| @@ -104,6 +104,12 @@ func NewJobSubmitCommand(streams genericclioptions.IOStreams) *cobra.Command { | |||
| Example: jobSubmitExample, | |||
| RunE: func(cmd *cobra.Command, args []string) error { | |||
| entryPointStart := cmd.ArgsLenAtDash() | |||
| if entryPointStart == -1 { | |||
There was a problem hiding this comment.
if entryPointStart == -1 || len(args[entryPointStart:]) == 0 {
There was a problem hiding this comment.
Can cmd.ArgsLenAtDash return -1? If so what does it mean?
There was a problem hiding this comment.
cmd.ArgsLenAtDash returning -1 just means that there isn't a "--"
chiayi
force-pushed
the
kubectl-plugin-quickfix
branch
from
6fbae08
to
90c56cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Check for
ray job submitentrypoint input from user.Currently if there is no "--", it will cause error with
panic: runtime error: slice bounds out of range [-1:].Or if there is no
entrypointinput after "--", the command will run through the whole cluster setup process and job submission step and then fail. Adding a check will ensure that it won't need to go through the whole setup/submission process.Related issue number
Checks