KubeRay: kubebuilder creat RayService Controller and CR #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brucez-anyscale
requested review from
chenk008,
Jeffwan,
DmitriGekhtman and
simon-mo
| ) | ||
|
|
||
| // EDIT THIS FILE! THIS IS SCAFFOLDING FOR YOU TO OWN! | ||
| // NOTE: json tags are required. Any new fields you add must have json tags for the fields to be serialized. |
There was a problem hiding this comment.
Just curious, does KubeBuilder auto-generate this file as an empty template?
There was a problem hiding this comment.
This one will auto generated if init by kubebuilder. But I do not think it is total empty
ray-operator/config/crd/patches/cainjection_in_rayservice_rayservices.yaml
Outdated
Show resolved
Hide resolved
ray-operator/config/crd/patches/webhook_in_rayservice_rayservices.yaml
Outdated
Show resolved
Hide resolved
brucez-anyscale
commented
May 24, 2022
ray-operator/config/crd/patches/cainjection_in_rayservice_rayservices.yaml
Outdated
Show resolved
Hide resolved
ray-operator/config/crd/patches/webhook_in_rayservice_rayservices.yaml
Outdated
Show resolved
Hide resolved
ray-operator/config/rbac/rayservice_rayservice_editor_role.yaml
Outdated
Show resolved
Hide resolved
ray-operator/config/rbac/rayservice_rayservice_viewer_role.yaml
Outdated
Show resolved
Hide resolved
ray-operator/config/samples/rayservice_v1alpha1_rayservice.yaml
Outdated
Show resolved
Hide resolved
|
Great! I will have a look later today. |
|
I suggest to move unrelated changes like renaming the backend service folder name to a separate PR and leave this PR for pure service controller changes. We are using squash merge and all these changes will be squash to single commit then. |
Jeffwan
reviewed
May 25, 2022
ray-operator/config/crd/patches/webhook_in_ray_rayservices.yaml
Outdated
Show resolved
Hide resolved
4 tasks
|
#275 is merged. Let's rebase the master and update this PR. |
|
Thanks. I have rebased this pr. |
|
Nice, the diff is much cleaner now. |
Jeffwan
approved these changes
May 31, 2022
|
Seems Dmitri has approved the changed as well and now we can merge the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
We plan to add a new RayService controller. This pr does the kubebuilder create api with basic implement. No real logic yet. Once this pr merged. We will start to implement logic for RayService.
Related issue number
#214
Checks