Sync crds to Helm chart #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ray-operator/Makefile
Outdated
| @@ -41,6 +41,7 @@ help: ## Display this help. | |||
|
|
|||
| manifests: controller-gen ## Generate WebhookConfiguration, ClusterRole and CustomResourceDefinition objects. | |||
| $(CONTROLLER_GEN) $(CRD_OPTIONS) rbac:roleName=kuberay-operator webhook paths="./..." output:crd:artifacts:config=config/crd/bases | |||
| $(KUSTOMIZE) build config/crd > ../helm-chart/kuberay-operator/crds/crd.yaml | |||
There was a problem hiding this comment.
do we want to put rbac also?
|
Thanks for the change. I am thinking whether we should have a separate make command just for sync instead of making changes to existing commands generated from kubebuilder. WDYT? |
Both are fine to me. I used this solution in my personal project. |
|
Added |
|
The change looks good to me. |
Jeffwan
approved these changes
Jun 2, 2022
|
Seems the failed test is not related to the change. Let me restart it and see what happened |
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
* Sync crds to Helm chart * Add make helm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Related issue number
Closes #240
Checks