Provide override for autoscaler image pull policy. #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DmitriGekhtman
commented
Jun 8, 2022
| customTimeout := int32(100) | ||
| customUpscaling := "Aggressive" | ||
| customUpscaling := rayiov1alpha1.UpscalingMode("Aggressive") |
There was a problem hiding this comment.
this is clean-up
DmitriGekhtman
commented
Jun 8, 2022
| @@ -358,15 +359,17 @@ func TestBuildPodWithAutoscalerOptions(t *testing.T) { | |||
| } | |||
|
|
|||
| cluster.Spec.AutoscalerOptions = &rayiov1alpha1.AutoscalerOptions{ | |||
| UpscalingMode: (*rayiov1alpha1.UpscalingMode)(&customUpscaling), | |||
| UpscalingMode: &customUpscaling, | |||
wuisawesome
reviewed
Jun 8, 2022
wuisawesome
approved these changes
Jun 8, 2022
DmitriGekhtman
changed the title
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
…y-project#297) This PR exposes the autoscaler container pull policy in the Ray CRD for testing purposes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR exposes the autoscaler container pull policy in the Ray CRD for testing purposes. This PR is needed for Ray CI testing purposes.
The CI environment needs to have the pull policy set to IfNotPresent, while for local testing the default policy of Always is more convenient.
A quick review is appreciated.
Related issue number
Checks