Update RayService CR to integrate with Ray Nightly #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brucez-anyscale
requested review from
simon-mo,
DmitriGekhtman and
shrekris-anyscale
|
@edoakes @DmitriGekhtman Please review this pr and see if we can merge it. Thanks |
DmitriGekhtman
approved these changes
Jul 5, 2022
There was a problem hiding this comment.
The parts not related to the serve schema look fine to me.
@edoakes @simon-mo or @shrekris-anyscale should review serve-specific content.
shrekris-anyscale
approved these changes
Jul 5, 2022
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
* draft for ha * import fmt * debug ingress * Draft service * update * fix * Update service logic * update * update * Logs * update * debug * Update * Update * Update * update * Fix cluster start flaky issue * update * Update service and ingress * update rbac * Draft v1 * Update * address comments * Address comments and refactor codes * update * Fix lint issue * update * Fix unit tests * goImport * Update unit tests * Implement unit tests * Change preparing to pending * goimports * update * Improve the pr to show both statuses * Improve the pr to show both statuses * update to align with latest serve status * update * Fix ut and imports * update * update * address comments * update * update delete ray cluster logic * update delete ray cluster logic * update * Apply new spec schema for serve deployment * use new schema * auto generate * auto generate * goimports * Update cpu number * update ut * update ut * update * update * update * update * address comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The ray nightly changes the serve endpoints. This pr applies the new schema.
Manual test results:
Related issue number
Checks