fix: bug in object store memory validation #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Noting some things (which will be added to docs): It's safest for Ray containers to set memory limits = memory request -- this is the surest way to avoid any inconsistencies in Ray's internal resource accounting. Ray and KubeRay generally use container resource limits to determine resource capacity. A large gap between requests and limits may introduce an inconsistency between what Ray thinks is available and what is actually available. It's usually best not to configure object store memory size manually -- best to leave it to Ray to configure it. That's done here. |
DmitriGekhtman
approved these changes
Jul 3, 2022
Jeffwan
reviewed
Jul 4, 2022
Jeffwan
reviewed
Jul 4, 2022
Jeffwan
reviewed
Jul 5, 2022
We are comparing memory to K8s Pod storage request instead of memory request. Add tests. Expand error message with more information. This error message is used in K8s events. More information here might be helpful. Update comments and log messages for clarity and smoother English usage. Make repeated strings constants.
Jeffwan
approved these changes
Jul 5, 2022
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
* fix: bug in object store memory validation We are comparing memory to K8s Pod storage request instead of memory request. Add tests. Expand error message with more information. This error message is used in K8s events. More information here might be helpful. Update comments and log messages for clarity and smoother English usage. Make repeated strings constants. * fixup: address PR feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are comparing memory to K8s Pod storage request
instead of memory request.
Add tests.
Expand error message with more information.
This error message is used in K8s events.
More information here might be helpful.
Update comments and log messages for clarity and smoother English usage.
Make repeated strings constants.
Checks