Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add EventReason type for events #334

Merged
merged 2 commits into from
Jul 5, 2022
Merged

feat: add EventReason type for events #334

merged 2 commits into from
Jul 5, 2022

Conversation

davidxia
Copy link
Contributor

@davidxia davidxia commented Jul 3, 2022 •
edited
Loading

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@davidxia davidxia marked this pull request as ready for review July 3, 2022 20:47
@DmitriGekhtman DmitriGekhtman mentioned this pull request Jul 3, 2022
Closed
4 tasks
@Jeffwan Jeffwan changed the title feat: add events package to be DRYer feat: add EventReason type for events Jul 5, 2022
@Jeffwan Jeffwan merged commit b9a60a4 into ray-project:master Jul 5, 2022
@davidxia davidxia deleted the dxia/patch8 branch July 5, 2022 19:33
lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
@davidxia
feat: add EventReason type for events (ray-project#334)
f14df8f 
* feat: add events package to be DRYer

* fixup commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DmitriGekhtman DmitriGekhtman DmitriGekhtman left review comments

@Jeffwan Jeffwan Awaiting requested review from Jeffwan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidxia @Jeffwan @DmitriGekhtman