Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Serve] Unify logger and add user facing events #378

Merged
merged 1 commit into from
Jul 15, 2022

Conversation

simon-mo
Copy link
Collaborator

Why are these changes needed?

The PR unified the two logger used in the rayservice controller, and adds user facing events, looking like the following

Events:
  Type    Reason                    Age                    From                   Message
  ----    ------                    ----                   ----                   -------
  Normal  WaitForDashboard          2m33s (x2 over 2m33s)  rayservice-controller  Service "rayservice-sample-raycluster-97tzg-dashboard-svc" not found
  Normal  FailedServeDeploy         2m29s                  rayservice-controller  Put "http://rayservice-sample-raycluster-97tzg-dashboard-svc.default.svc.cluster.local:52365/api/serve/deployments/": dial tcp 10.72.1.85:52365: i/o timeout (Client.Timeout exceeded while awaiting headers)
  Normal  FailedServeDeploy         2m21s (x4 over 2m31s)  rayservice-controller  Put "http://rayservice-sample-raycluster-97tzg-dashboard-svc.default.svc.cluster.local:52365/api/serve/deployments/": context deadline exceeded (Client.Timeout exceeded while awaiting headers)
  Normal  SubmittedServeDeployment  2m17s (x8 over 2m20s)  rayservice-controller  Controller sent API request to update Serve deployments on cluster rayservice-sample-raycluster-97tzg
  Normal  Running                   2m (x10 over 2m2s)     rayservice-controller  The Serve applicaton is now running and healthy.

Related issue number

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@Jeffwan
Copy link
Collaborator

Jeffwan commented Jul 14, 2022

The events are pretty helpful. great

@simon-mo simon-mo merged commit a3b8fc6 into ray-project:master Jul 15, 2022
lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants