[minor] Add client and dashboard ports to ports in example configs. #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dmitri Gekhtman <[email protected]>
2 tasks
wuisawesome
approved these changes
Jul 21, 2022
DmitriGekhtman
changed the title
|
Issue to discuss config simplification: |
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
…ect#399) Signed-off-by: Dmitri Gekhtman <[email protected]> Adds client and dashboard container ports to the `raycluster.complete` and `raycluster.autoscaler` example files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dmitri Gekhtman [email protected]
Why are these changes needed?
These ports should be exposed by the Ray head service by default.
For now, this PR adds the container ports to the
raycluster.completeandraycluster.autoscalerexample files, so that the service configured for these examples exposes the relevant ports.My main motivation right now is documenting Ray Cluster interaction methods in the Ray docs.
Related issue number
Checks