Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration test for kuberay ray service and improve ray service operator #415

Merged
merged 14 commits into from
Jul 26, 2022

Conversation

brucez-anyscale
Copy link
Contributor

@brucez-anyscale brucez-anyscale commented Jul 26, 2022

Why are these changes needed?

This pr adds basic integration test for ray service.
This pr also add requeue time for ray service controller to make it more responsible.
The k8s reconciler handles error in a backoff manner, which will make it reconcile once per several mins.
To avoid that, for reconcileServe, we do not return err but a requeue time to improve the overall RayService Experience.
Also change one status naming to make it less frightening.

Related issue number

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@DmitriGekhtman
Copy link
Collaborator

It appears there are some changes not related to testing.
Could you explain those changes in the PR description?

@brucez-anyscale
Copy link
Contributor Author

It appears there are some changes not related to testing. Could you explain those changes in the PR description?

Thanks. Add more info.

Copy link
Collaborator

@DmitriGekhtman DmitriGekhtman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable.
@simon-mo should also review

@simon-mo
Copy link
Collaborator

@wilsonwang371 confirming this is the right place to add integration test?
Also cc @Jeffwan we want to make sure this part of the release criteria of the 0.3.

@wilsonwang371
Copy link
Collaborator

@wilsonwang371 confirming this is the right place to add integration test? Also cc @Jeffwan we want to make sure this part of the release criteria of the 0.3.

@brucez-anyscale How about adding another test file to do this? Or maybe we can file another PR later to separate these tests into different files and run them in parallel.

@brucez-anyscale
Copy link
Contributor Author

@wilsonwang371 confirming this is the right place to add integration test? Also cc @Jeffwan we want to make sure this part of the release criteria of the 0.3.

@brucez-anyscale How about adding another test file to do this? Or maybe we can file another PR later to separate these tests into different files and run them in parallel.

sg. I think we can do it in another pr.

@Jeffwan Jeffwan merged commit 50d4782 into master Jul 26, 2022
@Jeffwan Jeffwan deleted the brucez/rayserviceTest branch July 26, 2022 20:07
lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
…operator (ray-project#415)

* Fix slow start issue for ray serve

* update

* update

* update

* update

* update

* update

* Add virtual start cpus

* rm kustomization.yaml

* update

* update

* update

* update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants