-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integration test for kuberay ray service and improve ray service operator #415
Conversation
It appears there are some changes not related to testing. |
Thanks. Add more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable.
@simon-mo should also review
@wilsonwang371 confirming this is the right place to add integration test? |
@brucez-anyscale How about adding another test file to do this? Or maybe we can file another PR later to separate these tests into different files and run them in parallel. |
sg. I think we can do it in another pr. |
…operator (ray-project#415) * Fix slow start issue for ray serve * update * update * update * update * update * update * Add virtual start cpus * rm kustomization.yaml * update * update * update * update
Why are these changes needed?
This pr adds basic integration test for ray service.
This pr also add requeue time for ray service controller to make it more responsible.
The k8s reconciler handles error in a backoff manner, which will make it reconcile once per several mins.
To avoid that, for reconcileServe, we do not return err but a requeue time to improve the overall RayService Experience.
Also change one status naming to make it less frightening.
Related issue number
Checks