RayCluster created by RayService set death info env for ray container #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jeffwan
reviewed
Jul 26, 2022
| @@ -513,6 +513,13 @@ func setContainerEnvVars(pod *v1.Pod, rayContainerIndex int, rayNodeType rayiov1 | |||
| portEnv := v1.EnvVar{Name: RAY_PORT, Value: headPort} | |||
| container.Env = append(container.Env, portEnv) | |||
| } | |||
| if createdByRayService { | |||
There was a problem hiding this comment.
I think thinking if there's better way to indicate a cluster is created by RayServe controller.
Can we leverage
and pass into the method.This help us not expand method arguments if we need some customization on clusters created by RayJob etc.
Jeffwan
approved these changes
Jul 26, 2022
|
The change looks good to me. Let's merge it after test complete |
| @@ -513,6 +513,13 @@ func setContainerEnvVars(pod *v1.Pod, rayContainerIndex int, rayNodeType rayiov1 | |||
| portEnv := v1.EnvVar{Name: RAY_PORT, Value: headPort} | |||
| container.Env = append(container.Env, portEnv) | |||
| } | |||
| if strings.ToLower(creator) == RayServiceCreatorLabelValue { | |||
| // Only add this env for Ray Service cluster to improve service SLA. | |||
There was a problem hiding this comment.
do we only need this in Ray Service? what about other scenarios?
There was a problem hiding this comment.
@iycheng mentioned this will increase SLA for ray service.
But for ray job, it will ignore the error info which is not good for observability. So for now, we keep it only for RayService.
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
…ray-project#419) * RayCluster created by RayService set death info env for ray container * update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
For Ray Serve, if we set the death info time as 0, it will increase SLA. This pr sets the env for RayService create Ray containers.
Related issue number
Checks