-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add envs in cluster service api #432
Add envs in cluster service api #432
Conversation
@Jeffwan This PR is ready to review. :) |
@@ -589,6 +589,9 @@ func setContainerEnvVars(pod *v1.Pod, rayContainerIndex int, rayNodeType rayiov1 | |||
} | |||
} | |||
} | |||
|
|||
// Set all fields in envs to the container. | |||
container.Env = append(container.Env, envs...) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we already set envs in the podTemplate, this would be unnecessary. this method set additional environments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
@Jeffwan Maybe we can merge this PR now. |
* debug * debug complete * remove useless code * add unit test * fix lint * fix tests * fix tests * fix tests * do not modify crd * fix lint * revert useless * fix duplicated envs
Why are these changes needed?
Add environment variables in ClusterService create cluster api. The json format looks like:
The ray operator set the environment variables in envs fields to all containers in the ray cluster.
Related issue number
Checks