Clean up example samples #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dmitri Gekhtman <[email protected]>
Signed-off-by: Dmitri Gekhtman <[email protected]>
Signed-off-by: Dmitri Gekhtman <[email protected]>
DmitriGekhtman
commented
Aug 3, 2022
| block: 'true' | ||
| num-cpus: '1' # can be auto-completed from the limits | ||
| # num-cpus: '1' # can be auto-completed from the limits |
There was a problem hiding this comment.
This is a foot-gun for people copying the config and modifying resource values. Hence, commented out.
Signed-off-by: Dmitri Gekhtman <[email protected]>
Signed-off-by: Dmitri Gekhtman <[email protected]>
Signed-off-by: Dmitri Gekhtman <[email protected]>
Signed-off-by: Dmitri Gekhtman <[email protected]>
Signed-off-by: Dmitri Gekhtman <[email protected]>
Signed-off-by: Dmitri Gekhtman <[email protected]>
Signed-off-by: Dmitri Gekhtman <[email protected]>
Signed-off-by: Dmitri Gekhtman <[email protected]>
Signed-off-by: Dmitri Gekhtman <[email protected]>
Signed-off-by: Dmitri Gekhtman <[email protected]>
Signed-off-by: Dmitri Gekhtman <[email protected]>
Signed-off-by: Dmitri Gekhtman <[email protected]>
Signed-off-by: Dmitri Gekhtman <[email protected]>
Jeffwan
approved these changes
Aug 3, 2022
|
great. These configuration are covered by codes. Looks good to me |
|
We could consider automatically configuring the init container and pre-stop hook in the 0.4.0 release. |
|
Just going to double check that the configs don't have any issues before merging. |
Signed-off-by: Dmitri Gekhtman <[email protected]>
Jeffwan
pushed a commit
to Jeffwan/kuberay
that referenced
this pull request
Aug 9, 2022
This PR cleans up the "complete" and "autoscaler" sample yamls a bit. Unnecessary pod spec fields are removed without sacrificing the completeness of the examples. The idea is to make the configuration look less intimidating. Signed-off-by: Dmitri Gekhtman <[email protected]>
Jeffwan
added a commit
that referenced
this pull request
Aug 10, 2022
* Fix nil pointer dereference (#429) Signed-off-by: Kevin Su <[email protected]> * Fix wrong ray start command (#431) Signed-off-by: Kevin Su <[email protected]> * Add ray state api doc link in ray service doc (#428) * Add ray state api doc link in ray service doc * Update doc * update * [doc] Fix config typos Signed-off-by: Dmitri Gekhtman <[email protected]> Fixes a couple of typos in recently introduced sample configs. * Add http resp code check for kuberay (#435) * Clean up example samples (#434) This PR cleans up the "complete" and "autoscaler" sample yamls a bit. Unnecessary pod spec fields are removed without sacrificing the completeness of the examples. The idea is to make the configuration look less intimidating. Signed-off-by: Dmitri Gekhtman <[email protected]> * Add more env for RayService head or worker pods (#439) * fix: worker node can't connect to head node service (#445) Signed-off-by: Kevin Su <[email protected]> * helm-chart/ray-cluster: allow head autoscaling (#443) Also allow setting rayVersion Signed-off-by: Christos Kotsis <[email protected]> * Disable async serve handler in Ray Service cluster (#447) * Add wget timeout to probes (#448) * Enable tests against release-0.3 branch Signed-off-by: Kevin Su <[email protected]> Signed-off-by: Dmitri Gekhtman <[email protected]> Signed-off-by: Christos Kotsis <[email protected]> Co-authored-by: Kevin Su <[email protected]> Co-authored-by: bruce <[email protected]> Co-authored-by: Dmitri Gekhtman <[email protected]> Co-authored-by: Christos Kotsis <[email protected]> Co-authored-by: Yi Cheng <[email protected]> Co-authored-by: Wilson Wang <[email protected]>
davidxia
reviewed
Aug 20, 2022
Comment on lines
-48
to
-72
| env: | ||
| - name: CPU_REQUEST | ||
| valueFrom: | ||
| resourceFieldRef: | ||
| containerName: ray-head | ||
| resource: requests.cpu | ||
| - name: CPU_LIMITS | ||
| valueFrom: | ||
| resourceFieldRef: | ||
| containerName: ray-head | ||
| resource: limits.cpu | ||
| - name: MEMORY_LIMITS | ||
| valueFrom: | ||
| resourceFieldRef: | ||
| containerName: ray-head | ||
| resource: limits.memory | ||
| - name: MEMORY_REQUESTS | ||
| valueFrom: | ||
| resourceFieldRef: | ||
| containerName: ray-head | ||
| resource: requests.memory | ||
| - name: MY_POD_IP | ||
| valueFrom: | ||
| fieldRef: | ||
| fieldPath: status.podIP |
There was a problem hiding this comment.
@DmitriGekhtman just curious if these env vars are deprecated and should no longer be used or if removing them will change Ray behavior? I'm using Ray 1.13.
There was a problem hiding this comment.
They're deprecated and can be safely removed.
davidxia
reviewed
Aug 20, 2022
Comment on lines
-167
to
-168
| ports: | ||
| - containerPort: 80 |
There was a problem hiding this comment.
@DmitriGekhtman what did this port used to be? Should we add the metrics port 8080?
There was a problem hiding this comment.
I have no idea what this port was doing here.
There was a problem hiding this comment.
I don't believe that the operator interacts with ports specified in workerGroupSpecs.
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
This PR cleans up the "complete" and "autoscaler" sample yamls a bit. Unnecessary pod spec fields are removed without sacrificing the completeness of the examples. The idea is to make the configuration look less intimidating. Signed-off-by: Dmitri Gekhtman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR cleans up the "complete" and "autoscaler" sample yamls a bit.
Unnecessary pod spec fields are removed without sacrificing the completeness of the examples.
The idea is to make the configuration look less intimidating.
Related issue number
Checks