sync up helm chart's role #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To address #440 |
Jeffwan
approved these changes
Aug 15, 2022
Jeffwan
pushed a commit
to Jeffwan/kuberay
that referenced
this pull request
Aug 16, 2022
Co-authored-by: chenyu.jiang <[email protected]>
Jeffwan
added a commit
that referenced
this pull request
Aug 16, 2022
* Update helm chart version to 0.3.0 (#461) * helm-charts/ray-cluster: Allow extra workers (#451) * helm-charts/ray-cluster: Allow extra workers We can not set additional workers with the current helm chart. There are some PRs that aim to fix this but they appear to be stale #266 We wanted to keep untouched the default worker that is already included in the helm chart but allow the addition of new workers. The changes are adding the following logic: - Allow to disable the default worker group, if needed, via worker.disabled = true - Allow to set additional workers by using the extraWorkers map The extraWorkers map has a different structure compared to the default worker because we wanted to add additional flexibility. Due to that, some variables in the extraWorkers have different naming (which matches the name of the related CRD attributed) Note: PR was done to support additional workers in the infrastructure of Metrika.co * Sync up helm chart's role (#472) Co-authored-by: chenyu.jiang <[email protected]> * Document the raycluster status (#473) Co-authored-by: chenyu.jiang <[email protected]> Co-authored-by: Christos Kotsis <[email protected]> Co-authored-by: Chenyu Jiang <[email protected]> Co-authored-by: chenyu.jiang <[email protected]>
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
Co-authored-by: chenyu.jiang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The operator deployed by the helm chart need permission for the rayjobs resource, the role is already update in the
ray-operator/config/rbac, we need sync up in the helm chart.Related issue number
#440
Checks