Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The deletion of workers has only been allowed through a scaleStrategy where the specific names of the pods to be removed has to be defined.
This PR keeps that logic, but adds the ability to remove random workers if the scaleStrategy does not define any specific pods.
E.g. if current running worker pods in a group is
5
and you modify the
replicas = 3
with only 1 pod in the scaleStrategy, e.g.Then the second to be removed will be randomly selected by the ray operator