Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow deletion of workers #5

Merged
merged 2 commits into from
Aug 1, 2021
Merged

allow deletion of workers #5

merged 2 commits into from
Aug 1, 2021

Conversation

akanso
Copy link
Collaborator

@akanso akanso commented Jul 31, 2021

The deletion of workers has only been allowed through a scaleStrategy where the specific names of the pods to be removed has to be defined.

This PR keeps that logic, but adds the ability to remove random workers if the scaleStrategy does not define any specific pods.

E.g. if current running worker pods in a group is 5
and you modify the replicas = 3 with only 1 pod in the scaleStrategy, e.g.

scaleStrategy:
     workersToDelete:
     - raycluster-complete-worker-small-group-bdtwh

Then the second to be removed will be randomly selected by the ray operator

@akanso akanso merged commit 4a56581 into master Aug 1, 2021
@Jeffwan Jeffwan deleted the alkanso/name-check branch October 16, 2021 20:31
lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant