-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Helm chart default configuration #530
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DmitriGekhtman
approved these changes
Sep 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great. Thanks for fixing this!
2 tasks
This was referenced Sep 15, 2022
DmitriGekhtman
pushed a commit
that referenced
this pull request
Sep 16, 2022
… for head node (#572) As mentioned in #495 and #530, the value of nameOverride needs to be hardcoded with the value "kuberay" to avoid the mismatch between head pod and head service. The value of app.kubernetes.io/name in the head pod's labels is same as app.kubernetes.io/name specified in RayCluster.Spec.HeadGroupSpec.Template.ObjectMeta.Labels of RayCluster custom resource YAML file. See the function labelPod in pod.go for more details. RayCluster.Spec.HeadGroupSpec.Template.ObjectMeta.Labels["app.kubernetes.io/name"] is controlled by the value of nameOverride in helm chart. However, the value of app.kubernetes.io/name in the head pod service's selector is hardcoded with the constant variable ApplicationName (= "kuberay")
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
Fix default Helm configuration.
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
… for head node (ray-project#572) As mentioned in ray-project#495 and ray-project#530, the value of nameOverride needs to be hardcoded with the value "kuberay" to avoid the mismatch between head pod and head service. The value of app.kubernetes.io/name in the head pod's labels is same as app.kubernetes.io/name specified in RayCluster.Spec.HeadGroupSpec.Template.ObjectMeta.Labels of RayCluster custom resource YAML file. See the function labelPod in pod.go for more details. RayCluster.Spec.HeadGroupSpec.Template.ObjectMeta.Labels["app.kubernetes.io/name"] is controlled by the value of nameOverride in helm chart. However, the value of app.kubernetes.io/name in the head pod service's selector is hardcoded with the constant variable ApplicationName (= "kuberay")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
There are 3 problems in current helm chart default configurations.
[Q1] There is a mismatch between labels in ray-head pod and selector in ray-head ClusterIP service. See [Bug] The mismatched labels configured in RayCluster Helm chart #495 for more details.
nameOverride
fromray
tokuberay
as mentioned by @jeethridge.[Q2] When I solved Q1, I found dashboard could not be launched successfully. The root cause is that
dashboard_agent
would round down the CPU request config (200m) to 0.[Q3] After I solved Q2, the dashboard still could not be rendered on my browser. The root cause is that the image
rayproject/ray:latest
points to a very old version. Thank @hckuo for pointing this out!Related issue number
#495
Checks