[Feature] Sync for manifests and helm chart #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DmitriGekhtman
approved these changes
Sep 14, 2022
There was a problem hiding this comment.
looks great to me (just a couple of grammar nits),
any thoughts @Jeffwan @scarlet25151?
Co-authored-by: Dmitri Gekhtman <[email protected]> Signed-off-by: Kai-Hsun Chen <[email protected]>
Co-authored-by: Dmitri Gekhtman <[email protected]> Signed-off-by: Kai-Hsun Chen <[email protected]>
|
Nice! Do we still need a PR with some logic to keep RBAC in sync? |
Oh, I think we need RBAC synchronization. I will open an issue. |
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
The CRD inconsistency between ray-operator/config/crd/bases/ and helm-chart/kuberay-operator/crds/ is possible to cause bugs like ray-project#538. Hence, we need to check the consistency in GitHub Actions. Signed-off-by: Kai-Hsun Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The CRD inconsistency between
ray-operator/config/crd/bases/andhelm-chart/kuberay-operator/crds/is possible to cause bugs like #538. Hence, we need to check the consistency in GitHub Actions.Related issue number
Closes #446
#538
Checks
#565 is the control group.