[Doc] Cannot build kuberay with Go 1.16 #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ray-operator/DEVELOPMENT.md
Outdated
|
|
||
| ### Setup on Kind | ||
|
|
||
| For a local [kind](https://kind.sigs.k8s.io/) environment setup, you can follow the Jupyter Notebook example: [KubeRay-on-kind](../docs/notebook/kuberay-on-kind.ipynb). | ||
|
|
||
| ### Use go v1.17 | ||
|
|
||
| Currently, Kuberay does not support go v1.16 ([#568](https://github.com/ray-project/kuberay/issues/568)) and go v1.18 ([#518](https://github.com/ray-project/kuberay/issues/518)). |
There was a problem hiding this comment.
Grammar nit:
and -> or because there's a negation (not)
It's as if English grammar follows De Morgan's law... but actually English grammar is just plain bizarre.
There was a problem hiding this comment.
Cool, I just wrote the sentence with De Morgan's law lol. Thank you for letting me know. Updated.
DmitriGekhtman
approved these changes
Sep 16, 2022
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
Updates Development docs to indicate the KubeRay build currently requires Go 1.17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
See #568.
Related issue number
Closes #568
Checks