Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kuberay int with MCAD #598

Merged
merged 8 commits into from
Sep 28, 2022
Merged

kuberay int with MCAD #598

merged 8 commits into from
Sep 28, 2022

Conversation

asm582
Copy link
Contributor

@asm582 asm582 commented Sep 27, 2022

Why are these changes needed?

This is a documentation PR that provides the capability to queue and gang dispatch kuberay clusters using MCAD project.

Related issue number

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@DmitriGekhtman
Copy link
Collaborator

DmitriGekhtman commented Sep 27, 2022 •
edited
Loading

I left some small comments.

Also, could you make sure the new page is accessible from doc homepage via links / tables of contents?
There are some notes in DEVELOPMENT.md on how to view your development version of the docs locally.

@asm582
Copy link
Contributor Author

asm582 commented Sep 27, 2022 •
edited
Loading

I left some small comments.

Also, could you make sure the new page is accessible from doc homepage via links / tables of contents? There are some notes in DEVELOPMENT.md on how to view your development version of the docs locally.

@DmitriGekhtman I confirm that docs are accessible locally after the last commit to nav, thanks for the review

@asm582 asm582 mentioned this pull request Sep 28, 2022
Closed
2 tasks
DmitriGekhtman
DmitriGekhtman reviewed Sep 28, 2022
View reviewed changes
docs/deploy/kuberay-with-MCAD.md Outdated Show resolved Hide resolved
docs/deploy/kuberay-with-MCAD.md Outdated Show resolved Hide resolved
docs/deploy/kuberay-with-MCAD.md Outdated Show resolved Hide resolved
docs/deploy/kuberay-with-MCAD.md Outdated Show resolved Hide resolved
@DmitriGekhtman
Copy link
Collaborator

DmitriGekhtman commented Sep 28, 2022 •
edited
Loading

(previously forgot to complete a review and submit comments)

DmitriGekhtman
DmitriGekhtman reviewed Sep 28, 2022
View reviewed changes
Copy link
Collaborator

@DmitriGekhtman DmitriGekhtman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more nits

docs/deploy/kuberay-with-MCAD.md Outdated Show resolved Hide resolved
docs/deploy/kuberay-with-MCAD.md Outdated Show resolved Hide resolved
docs/deploy/kuberay-with-MCAD.md Outdated Show resolved Hide resolved
docs/deploy/kuberay-with-MCAD.md Outdated Show resolved Hide resolved
docs/deploy/kuberay-with-MCAD.md Outdated Show resolved Hide resolved
docs/deploy/kuberay-with-MCAD.md Outdated Show resolved Hide resolved
docs/deploy/kuberay-with-MCAD.md Outdated Show resolved Hide resolved
DmitriGekhtman
DmitriGekhtman reviewed Sep 28, 2022
View reviewed changes
Copy link
Collaborator

@DmitriGekhtman DmitriGekhtman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

final nits

docs/deploy/kuberay-with-MCAD.md Outdated Show resolved Hide resolved
docs/deploy/kuberay-with-MCAD.md Outdated Show resolved Hide resolved
DmitriGekhtman
DmitriGekhtman reviewed Sep 28, 2022
View reviewed changes
mkdocs.yml Outdated Show resolved Hide resolved
DmitriGekhtman
DmitriGekhtman reviewed Sep 28, 2022
View reviewed changes
mkdocs.yml Outdated Show resolved Hide resolved
@asm582
Copy link
Contributor Author

asm582 commented Sep 28, 2022

This is a documentation PR and I am not sure if the build failing is related to this PR

@DmitriGekhtman
Copy link
Collaborator

This is a documentation PR and I am not sure if the build failing is related to this PR

It's unrelated. Looks good to merge. Thank you!

DmitriGekhtman
DmitriGekhtman approved these changes Sep 28, 2022
View reviewed changes
Copy link
Collaborator

@DmitriGekhtman DmitriGekhtman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@DmitriGekhtman DmitriGekhtman merged commit d3abf2b into ray-project:master Sep 28, 2022
lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
@asm582
kuberay int with MCAD (ray-project#598)
c48ff63 
This is a documentation PR that provides the capability to queue and gang dispatch kuberay clusters using MCAD project.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DmitriGekhtman DmitriGekhtman DmitriGekhtman approved these changes

@Jeffwan Jeffwan Awaiting requested review from Jeffwan

@akanso akanso Awaiting requested review from akanso

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asm582 @DmitriGekhtman