[RayService] Revert "Disable async serve handler in Ray Service cluster (#447)" #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit de8e242.
shrekris-anyscale
requested review from
simon-mo,
DmitriGekhtman and
brucez-anyscale
|
This flag should be enabled for HA purpose "opt-in" instead of on by default. |
simon-mo
approved these changes
Sep 29, 2022
brucez-anyscale
approved these changes
Sep 29, 2022
|
This is not relevant for job. |
4 tasks
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
…ct#447)" (ray-project#606) This reverts commit eaa6790. Why are these changes needed? Ray 2.0 lets users build their Serve deployment graphs using async handles. However, KubeRay disables async handles by default. Once users build their deployment graphs, they attempt to use it with KubeRay but must add code changes to remove double await statements used with async handles. See Issue #28908 in the Ray repo for more info. This change removes the logic that disables async handles in KubeRay.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit de8e242.
Why are these changes needed?
Ray 2.0 lets users build their Serve deployment graphs using async handles. However, KubeRay disables async handles by default. Once users build their deployment graphs, they attempt to use it with KubeRay but must add code changes to remove double
awaitstatements used with async handles. See Issue #28908 in the Ray repo for more info.This change removes the logic that disables async handles in KubeRay.
Related issue number
See Issue #28908 in the Ray repo for more info.
Checks