Helm: add service type configuration to head group for ray-cluster #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DmitriGekhtman
approved these changes
Oct 7, 2022
There was a problem hiding this comment.
This looks good to me.
@kevin85421 would you mind taking a look as well?
Jeffwan
approved these changes
Oct 11, 2022
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
…ay-project#614) Co-authored-by: Iskandar Sitdikov <[email protected]> Currently service type is not used in Helm and ClusterIP is hardcoded. This commit fixes that so that the service type in values.yaml is used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Currently service type is not used in helm and ClusterIP is hardcoded
kuberay/helm-chart/ray-cluster/templates/raycluster-cluster.yaml
Line 15 in 159d57f
Related issue number
Checks