[Feature] Sync logs to local file #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
manual testing through replace the based image in dockerfile. |
Jeffwan
requested changes
Oct 18, 2022
|
Overall the change looks good to me beside the parameter pattern |
Basasuya
force-pushed
the
basasuya_master_write_to_file
branch
from
e722268
to
ee0f729
Compare
kevin85421
reviewed
Oct 19, 2022
|
@Basasuya can you help address @kevin85421's comment? |
Basasuya
force-pushed
the
basasuya_master_write_to_file
branch
from
ee0f729
to
97aac7b
Compare
|
@kevin85421 sorry for the slow reply, I have rebase the master again. |
kevin85421
reviewed
Oct 28, 2022
I add the detail in PR description. |
kevin85421
approved these changes
Oct 31, 2022
|
@Jeffwan is this PR ready to merge? The merge is blocked by your change requests. Thank you! |
Jeffwan
approved these changes
Nov 1, 2022
|
@kevin85421 Yeah, it looks good to me. |
2 tasks
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
* [logger] sync to file * fix for UT * default not output to file * fix for UT * fix for review * fix for review Co-authored-by: huyuanzhe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
support sync log to file in pod.
this feature is controllered by
log_fileparameter in command line, default only output log to stdRelated issue number
#593
Checks
Usage
use
-logFilePath=output.txtwhen executing apiserveruse
-log-file-path=output.txtwhen executing ray-operatoryou can add these parameter in ENTRYPOINT of Dockerfile
then swap the based image in Dockerfile which can exec into