[Feature][Helm] Align the key of minReplicas and maxReplicas

[orcahmlee]

Signed-off-by: Andrew Li [email protected]

Why are these changes needed?

This PR aligns the minReplicas and maxReplicas.
Since the RayCluster CRD uses minReplicas and maxReplicas, the values.yaml should use it instead of using miniReplicas and maxiReplicas

Related issue number

Checks

• [] I've made sure the tests are passing.
• Testing Strategy
  • Unit tests
  • Manual tests
  • This PR is not tested :(

[orcahmlee]

Hi @DmitriGekhtman ,
Would you mind reviewing this PR?

[DmitriGekhtman]

I agree, but we also need to ensure backwards compatibility of existing values.yaml files.

Would you mind modifying the template such that it understands "maxiReplicas"/"miniReplicas" but ignores these fields if "maxReplicas"/"minReplicas" is specified?

@kevin85421 can help with reviewing and getting this merged.

[kevin85421]

Thank @orcahmlee for your contribution!

We may also need to update miniReplicas and maxiReplicas in values.yaml to minReplicas and maxReplicas. Currently, this PR can pass the helm chart lint tests because it uses the default functions.

In addition, as @DmitriGekhtman said, we need to keep backward compatibility.

kuberay/helm-chart/ray-cluster/values.yaml

Lines 116 to 117 in 0adc508

	miniReplicas: 1
	maxiReplicas: 3

[orcahmlee]

Thank @orcahmlee for your contribution!

We may also need to update miniReplicas and maxiReplicas in values.yaml to minReplicas and maxReplicas. Currently, this PR can pass the helm chart lint tests because it uses the default functions.

In addition, as @DmitriGekhtman said, we need to keep backward compatibility.

Hi @kevin85421 ,
Would you mind reviewing it again?

[kevin85421]

Thank you for the update. Maybe we can use default to simplify the logic. You can refer to this commit: kevin85421@28138f4

[orcahmlee]

Maybe we can use default to simplify the logic. You can refer to this commit: kevin85421@28138f4

Thanks for your reminder and the kindly sample code. I haven't used the nested default function.
I've updated a new commit, please review it.