-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add clientset for rayclusters #78
Conversation
@harryge00 Thanks for the contribution. I fully understand the background and scope of this PR. Let's add some description in the PR for other reviewer? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- We also need a script to generate the clientset. Can you please add it as well?
- Just like to confirm we have to restructure api folder. Is that correct? Support clientset for RayCluster objects #29 (comment)
// +k8s:defaulter-gen=TypeMeta | ||
// +groupName=raycluster | ||
|
||
package v1alpha1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
empty line after this line
@harryge00 Can you help address the comments? |
I am thinking maybe we can split PRs into smaller ones?
What do you think? @harryge00 @chenk008 |
@Jeffwan |
If this PR blocks u, u can take it and make a small one first. 😭 |
@harryge00 no worries, Could I know what's the problem of |
@harryge00 Can you reach out to me on Ray or Kubernetes Slack channel? I can help you figure this out. |
Why are these changes needed?
RayCluster
is a kubernetes CRD objects we use for generating ray clusters and manage its life cycle. We need using codegen tools to generate clientset, informers automatically.Related issue number
#29
Checks