Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[helm] Add memory limits and resource documentation. #789

Merged
merged 3 commits into from
Dec 6, 2022
Merged

[helm] Add memory limits and resource documentation. #789

merged 3 commits into from
Dec 6, 2022

Conversation

DmitriGekhtman
Copy link
Collaborator

Signed-off-by: Dmitri Gekhtman [email protected]

Closes #788
See the issue for further context.

Manually tested as follows:

helm install kuberay-operator kuberay-operator/
helm install raycluster ray-cluster/

Confirmed that resource requests and limits are as expected.
Confirmed correct Ray internal state using

kubectl exec -it <head-pod> -- ray status

which produced the output

======== Autoscaler status: 2022-12-05 11:34:13.524240 ========
Node status
---------------------------------------------------------------
Healthy:
 1 node_310f01ea0047365c5f0d8c09c360de5b030c14debaa3d109795a6cf7
 1 node_b9725b30f0d8e9b15eb1f10952e56d76538ceef949cff07a2cc78855
Pending:
 (no pending nodes)
Recent failures:
 (no failures)

Resources
---------------------------------------------------------------
Usage:
 0.0/2.0 CPU
 0.00/2.794 GiB memory
 0.00/0.739 GiB object_store_memory

Demands:

@DmitriGekhtman DmitriGekhtman added this to the v0.4.0 release milestone Dec 5, 2022
@DmitriGekhtman
capitalization
f4465c9 
Signed-off-by: Dmitri Gekhtman <[email protected]>
@DmitriGekhtman
Copy link
Collaborator Author

Passes all Helm checks currently in the CI.

@DmitriGekhtman DmitriGekhtman merged commit 0b54d6e into ray-project:master Dec 6, 2022
DmitriGekhtman added a commit to DmitriGekhtman/kuberay that referenced this pull request Dec 6, 2022
@DmitriGekhtman
[helm] Add memory limits and resource documentation. (ray-project#789)
eec3ad1 
Adds appropriate memory limits to Helm chart, with some documentation.

Signed-off-by: Dmitri Gekhtman <[email protected]>
@DmitriGekhtman DmitriGekhtman mentioned this pull request Dec 6, 2022
Merged
4 tasks
DmitriGekhtman added a commit that referenced this pull request Dec 6, 2022
@DmitriGekhtman
[helm] Add memory limits and resource documentation. (#789) (#798)
d760b9c 
* [helm] Add memory limits and resource documentation. (#789)

Adds appropriate memory limits to Helm chart, with some documentation.

Signed-off-by: Dmitri Gekhtman <[email protected]>
lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
@DmitriGekhtman
[helm] Add memory limits and resource documentation. (ray-project#789)
da38fce 
Adds appropriate memory limits to Helm chart, with some documentation.

Signed-off-by: Dmitri Gekhtman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sihanwang41 sihanwang41 sihanwang41 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.4.0 release
Development

Successfully merging this pull request may close these issues.

[Bug] Add memory requests and limits to RayCluster Helm charts
2 participants
@DmitriGekhtman @sihanwang41