Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linter job for github workflow #79

Merged
merged 1 commit into from
Oct 19, 2021
Merged

Add linter job for github workflow #79

merged 1 commit into from
Oct 19, 2021

Conversation

feilengcui008
Copy link
Contributor

@feilengcui008 feilengcui008 commented Oct 19, 2021

Why are these changes needed?

Add golang-ci linter

Related issue number

#76

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@feilengcui008 feilengcui008 changed the title [WIP]Add linter job for github workflow Add linter job for github workflow Oct 19, 2021
@Jeffwan
Copy link
Collaborator

Jeffwan commented Oct 19, 2021

@feilengcui008 Thanks for fixing existing lint issue. This is great!

@Jeffwan Jeffwan merged commit a8556d9 into ray-project:master Oct 19, 2021
Copy link
Collaborator

@Jeffwan Jeffwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution

lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants