Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RayCluster controller] [Bug] Unconditionally reconcile RayCluster every 60s instead of only upon change #850

Merged
merged 6 commits into from
Jan 24, 2023
Merged

[RayCluster controller] [Bug] Unconditionally reconcile RayCluster every 60s instead of only upon change #850

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
368dd36
Reconcile when cluster pods are Pending
architkulkarni Dec 30, 2022
37fec45
Revert "Reconcile when cluster pods are Pending"
architkulkarni Dec 30, 2022
f4486df
Requeue RayCluster reconciliation if "successful"
architkulkarni Dec 30, 2022
251a18f
Change unconditional requeue from 2s to 60s
architkulkarni Jan 20, 2023
8daedca
Merge branch 'master' of https://github.com/ray-project/kuberay into …
architkulkarni Jan 20, 2023
9d50cbd
Use env var with default 300s and log
architkulkarni Jan 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion ray-operator/controllers/ray/raycluster_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ package ray
import (
"context"
"fmt"
"os"
"strconv"
"strings"
"time"

Expand Down Expand Up @@ -234,7 +236,17 @@ func (r *RayClusterReconciler) rayClusterReconcile(request ctrl.Request, instanc
}
}

return ctrl.Result{}, nil
// Unconditionally requeue after the number of seconds specified in the
// environment variable RAYCLUSTER_DEFAULT_RECONCILE_LOOP_S. If the
// environment variable is not set, requeue after 5 minutes.
var requeueAfterSeconds int
requeueAfterSeconds, err := strconv.Atoi(os.Getenv("RAYCLUSTER_DEFAULT_RECONCILE_LOOP_S"))
if err != nil {
r.Log.Info("RAYCLUSTER_DEFAULT_RECONCILE_LOOP_S is not set, using default value 300s", "cluster name", request.Name)
requeueAfterSeconds = 5 * 60
}
r.Log.Info("Unconditional requeue after", "cluster name", request.Name, "seconds", requeueAfterSeconds)
return ctrl.Result{RequeueAfter: time.Duration(requeueAfterSeconds) * time.Second}, nil
}

func (r *RayClusterReconciler) reconcileIngress(instance *rayiov1alpha1.RayCluster) error {
Expand Down