Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] KubeRay does not work on M1 macs. #869

Merged
merged 2 commits into from
Jan 30, 2023

Conversation

kevin85421
Copy link
Member

@kevin85421 kevin85421 commented Jan 15, 2023

Why are these changes needed?

The nightly docker images for arm64 are available. See ray-project/ray#31537 (comment) for more details. Hence, users can run Ray in Docker containers on ARM machines (including Mac M1) and on ARM cloud instances (e.g. AWS Graviton).

Related issue number

Closes #523

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(
# Step 1: Create a KinD cluster 
kind create cluster

# Step 2: Register a Helm chart repo
helm repo add kuberay https://ray-project.github.io/kuberay-helm/

# Step 3: Install both CRDs and KubeRay operator v0.4.0.
helm install kuberay-operator kuberay/kuberay-operator --version 0.4.0

# Step 4: Install a RayCluster custom resource
helm install raycluster kuberay/ray-cluster --version 0.4.0 --set image.tag=nightly-aarch64

# Step 5: Forward the port of Dashboard
kubectl port-forward --address 0.0.0.0 svc/raycluster-kuberay-head-svc 8265:8265

# Step 6: Check 127.0.0.1:8265 for the Dashboard

# Step 7: Log in to Ray head Pod and execute a job.
kubectl exec -it ${RAYCLUSTER_HEAD_POD} -- bash
python -c "import ray; ray.init(); print(ray.cluster_resources())" # (in Ray head Pod)

Screen Shot 2023-01-27 at 8 03 26 AM

Screen Shot 2023-01-27 at 8 03 37 AM

@kevin85421 kevin85421 marked this pull request as ready for review January 15, 2023 05:42
@kevin85421 kevin85421 changed the title [Bug] KubeRay seems not to work on minikube on M1 macs. [Bug] KubeRay seems not to work on M1 macs. Jan 15, 2023
@kevin85421 kevin85421 changed the title [Bug] KubeRay seems not to work on M1 macs. [Bug] KubeRay does not work on M1 macs. Jan 15, 2023
Copy link

@jiwq jiwq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks @kevin85421 for the good work, it helps me to resolve problem.

@kevin85421
Copy link
Member Author

kevin85421 commented Jan 18, 2023

Do not merge this PR. @jiwq found that the raylet processes will not be launched. We need to wait for the Ray community to fix this issue.

ray-project/ray#31736

@kevin85421 kevin85421 changed the title [Bug] KubeRay does not work on M1 macs. (DO NOT MERGE) [Bug] KubeRay does not work on M1 macs. Jan 18, 2023
@kevin85421
Copy link
Member Author

kevin85421 commented Jan 27, 2023

The nightly docker images for arm64 are available. See ray-project/ray#31537 (comment) for more details. I have already updated this PR and PR description.

cc @jiwq @DmitriGekhtman @krfricke @architkulkarni @Jeffwan

@kevin85421 kevin85421 requested review from jiwq and krfricke and removed request for jiwq January 27, 2023 16:08
@kevin85421 kevin85421 changed the title (DO NOT MERGE) [Bug] KubeRay does not work on M1 macs. [Bug] KubeRay does not work on M1 macs. Jan 27, 2023
Copy link

@jiwq jiwq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 Worked well in my m1, thanks @kevin85421

Copy link
Contributor

@architkulkarni architkulkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested manually on M1, works for me!

@kevin85421
Copy link
Member Author

Thank @jiwq @architkulkarni for the review! Merge this PR. The CI failure is due to #852.

@kevin85421 kevin85421 merged commit e4d4839 into ray-project:master Jan 30, 2023
lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
The nightly docker images for arm64 are available. See ray-project/ray#31537 (comment) for more details. Hence, users can run Ray in Docker containers on ARM machines (including Mac M1) and on ARM cloud instances (e.g. AWS Graviton).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] KubeRay seems not to work on minikube on M1 macs.
3 participants