Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove redundant import in raycluster_controller.go #884

Merged
merged 1 commit into from
Jan 28, 2023
Merged

refactor: remove redundant import in raycluster_controller.go #884

merged 1 commit into from
Jan 28, 2023

Conversation

davidxia
Copy link
Contributor

@davidxia davidxia commented Jan 25, 2023 •
edited
Loading

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@davidxia davidxia marked this pull request as ready for review January 25, 2023 15:11
@davidxia
Copy link
Contributor Author

cc @kevin85421

kevin85421
kevin85421 reviewed Jan 27, 2023
View reviewed changes
Copy link
Member

@kevin85421 kevin85421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

volcano_scheduler.go has the same issue. Would you mind updating the file in this PR? Thank you!

kuberay/ray-operator/controllers/ray/batchscheduler/volcano/volcano_scheduler.go

Lines 7 to 8 in db0ee96

corev1 "k8s.io/api/core/v1"
v1 "k8s.io/api/core/v1"

@davidxia
Copy link
Contributor Author

yup, done!

kevin85421
kevin85421 approved these changes Jan 28, 2023
View reviewed changes
Copy link
Member

@kevin85421 kevin85421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @davidxia for this contribution! LGTM

@kevin85421
Copy link
Member

The CI failure is due to #852. Merge it.

@kevin85421 kevin85421 merged commit 9209ceb into ray-project:master Jan 28, 2023
lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
@davidxia
refactor: remove redundant import in raycluster_controller.go and `…
de0aaf5 
…volcano_scheduler.go` (ray-project#884)

remove redundant import in `raycluster_controller.go` and `volcano_scheduler.go`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevin85421 kevin85421 kevin85421 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidxia @kevin85421