Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure container ports without names are also included in the head node service #891

Merged
merged 11 commits into from
Feb 14, 2023
Merged

Ensure container ports without names are also included in the head node service #891

Changes from 2 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
c0ed0d0
assign svc port name if not given by user
Yicheng-Lu-llll Jan 31, 2023
bcf6ecd
assign svc port name if not given by user
Yicheng-Lu-llll Jan 31, 2023
1285892
Merge branch 'ray-project:master' into PortsWithoutNameAreIgnored
Yicheng-Lu-llll Feb 4, 2023
1b96167
add test
Yicheng-Lu-llll Feb 4, 2023
3b93062
improve format
Yicheng-Lu-llll Feb 4, 2023
fbf5064
fix: `.status.availableWorkerReplicas` (#887)
davidxia Feb 5, 2023
c0e5710
use k8sClient from client.New in controller test (#898)
Yicheng-Lu-llll Feb 8, 2023
33f5fd2
Empty-Commit
Yicheng-Lu-llll Feb 9, 2023
057683d
Merge branch 'ray-project:master' into PortsWithoutNameAreIgnored
Yicheng-Lu-llll Feb 9, 2023
c82aa3c
add comment
Yicheng-Lu-llll Feb 11, 2023
beb4a95
add comment
Yicheng-Lu-llll Feb 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ray-operator/controllers/ray/common/service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
package common

import (
"fmt"

corev1 "k8s.io/api/core/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"

Expand Down Expand Up @@ -181,6 +183,9 @@ func getPortsFromCluster(cluster rayiov1alpha1.RayCluster) (map[string]int32, er
index := utils.FindRayContainerIndex(cluster.Spec.HeadGroupSpec.Template.Spec)
cPorts := cluster.Spec.HeadGroupSpec.Template.Spec.Containers[index].Ports
for _, port := range cPorts {
if port.Name == "" {
port.Name = fmt.Sprint(port.ContainerPort) + "-port"
}
svcPorts[port.Name] = port.ContainerPort
}

Expand Down