-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Improve and fix Prometheus & Grafana integrations #895
Conversation
cc @Yicheng-Lu-llll would you mind reviewing this PR? Thanks! |
Gentle ping @scarlet25151. Would you mind taking a look at this PR? Thank you! |
|
||
```sh | ||
# Forward the port of Grafana | ||
kubectl port-forward --address 0.0.0.0 deployment/prometheus-grafana -n prometheus-system 3000:3000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got this error at this step:
Unable to listen on port 3000: Listeners failed to create with the following errors: [unable to create listener: Error listen tcp4 0.0.0.0:3000: bind: address already in use]
error: unable to listen on any of the requested ports: [{3000 3000}]
But I'm not sure what could be using port 3000. Do I need to cancel one of the previous steps?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like I already have grafana running for some reason, I think it's unrelated to this tutorial:
sudo lsof -i :3000
Password:
COMMAND PID USER FD TYPE DEVICE SIZE/OFF NODE NAME
grafana-s 3915 archit 21u IPv6 0xd6d807306e5fa78f 0t0 TCP *:hbci (LISTEN)
Let me figure out how to stop it. I don't know if it's a common enough situation to mention in this document.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Naively killed the process but it kept restarting. The solution here https://unix.stackexchange.com/questions/601063/port-3000-is-always-being-hogged-by-grafana-server
is to run brew services stop grafana
. Probably don't need to mention in this doc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Went through the tutorial, it all works! Left some minor suggestions.
…ect#895) The old document (observability.md) of Prometheus and Grafana has some issues that make users hard to follow. This PR fixes these issues.
Why are these changes needed?
The old document (observability.md) of Prometheus and Grafana has some issues that make users hard to follow.
Inconsistency between install.sh and observability.md
Inconsistency between observability.md and KubeRay operator kuberay/#230.
Some missing pieces:
serviceMonitorSelector
andpodMonitorSelector
.Related issue number
Closes #871
Checks
config/grafana/dashboard_default.json
.