Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update apiserver chart location in readme #896

Merged
merged 4 commits into from
Feb 25, 2023

Conversation

psschwei
Copy link
Contributor

@psschwei psschwei commented Feb 6, 2023

Signed-off-by: Paul S. Schweigert [email protected]

Why are these changes needed?

The README for the apiserver has an incorrect location for the helm chart (see below). This PR updates the READ to use the correct helm chart location.

$ helm -n ray-system install kuberay-apiserver kuberay/helm-chart/kuberay-apiserver
Error: INSTALLATION FAILED: chart "helm-chart/kuberay-apiserver" matching  not found in kuberay index. (try 'helm repo update'): no chart name found

$ helm -n ray-system install kuberay-apiserver kuberay/kuberay-apiserver
NAME: kuberay-apiserver
LAST DEPLOYED: Mon Feb  6 12:02:18 2023
NAMESPACE: ray-system
STATUS: deployed
REVISION: 1
TEST SUITE: None

Related issue number

n/a

Checks

Note: this PR updates a readme, so there shouldn't be any impact to the tests.

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@psschwei
Copy link
Contributor Author

psschwei commented Feb 6, 2023

Adding @Jeffwan @scarlet25151 for review

Copy link
Member

@kevin85421 kevin85421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you can provide the methods to install the stable release chart from Helm repo and the nightly chart via cloning KubeRay repo. You can refer to this doc.

Signed-off-by: Paul S. Schweigert <[email protected]>
@psschwei
Copy link
Contributor Author

psschwei commented Feb 7, 2023

@kevin85421 I added an "Installing" section at the beginning to cover the various install scenarios

apiserver/README.md Outdated Show resolved Hide resolved
@kevin85421
Copy link
Member

Gentle ping some KubeRay APIServer folks for review. @Jeffwan @scarlet25151 @wilsonwang371

Signed-off-by: Paul S. Schweigert <[email protected]>
@wilsonwang371
Copy link
Collaborator

chenyu and jiaxin are more familiar with apiserver

apiserver/README.md Outdated Show resolved Hide resolved
apiserver/README.md Outdated Show resolved Hide resolved
apiserver/README.md Outdated Show resolved Hide resolved
Signed-off-by: Paul S. Schweigert <[email protected]>
@Jeffwan
Copy link
Collaborator

Jeffwan commented Feb 25, 2023

sorry for late. thanks for the correction and the change looks good to me

@kevin85421
Copy link
Member

This PR only updates the document, so it has no relationship with the CI failure. Merge it.

@kevin85421 kevin85421 merged commit 02135a4 into ray-project:master Feb 25, 2023
lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants