Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix leader election failure and crd too long issue #9

Merged
merged 3 commits into from
Aug 4, 2021
Merged

Fix leader election failure and crd too long issue #9

merged 3 commits into from
Aug 4, 2021

Commits on Aug 4, 2021

  1. Fix leader election problem 

    Original name has a “.” which doesn’t meet requirement of  DNS-1123 (subdomain must consist of lower case alphanumeric characters,  '-' or '.', and must start and end with an alphanumeric character)
    @Jeffwan
    Jeffwan committed Aug 4, 2021
    Configuration menu
    Copy the full SHA
    8bbbbc3 View commit details
    Browse the repository at this point in the history

  2. Add README.md and CONTRIBUTING.md

    @Jeffwan
    Jeffwan committed Aug 4, 2021
    Configuration menu
    Copy the full SHA
    89fcb1b View commit details
    Browse the repository at this point in the history

  3. Fix crd too long issue 

    Since auto generated crd embed PodTemplateSpec, it results in some failures like `The CustomResourceDefinition "..." is invalid: metadata.annotations: Too long: must have at most 262144 characters`

Everytime we run `kubectl apply`, it will sets the kubectl.kubernetes.io/last-applied-configuration: '{...}' annotation on each object. The annotation contains the contents of the object configuration file that was used to create the object."

Using kubectl create helps workaround the issue but create will fail if crd exist so it need us to change logics to check and create.

In end end, we specify `maxDescLen` on controller-tools when generating the CRD and it helps reduce size.
    @Jeffwan
    Jeffwan committed Aug 4, 2021
    Configuration menu
    Copy the full SHA
    703160b View commit details
    Browse the repository at this point in the history